Skip to content

ImportProjectJob: advertise as Killable

Igor Kushnir requested to merge work/killable-importprojectjob into master

ImportProjectJob overrides doKill() but fails to set the Killable capability.

ImportProjectJob is created in a single place: IProjectFileManager::createImportJob(). All classes, that directly or indirectly inherit IProjectFileManager, also inherit AbstractFileManagerPlugin, which overrides createImportJob(). That is, all except for class FakeFileManager, which is defined and used only within test_projectcontroller. Therefore only this test is affected by the missing Killable capability of ImportProjectJob.

This commit eliminates lots of almost identical warnings from the output of test_projectcontroller:

kdevplatform.shell: non-killable job KDevelop::ImportProjectJob(0x5613b26a9ed0, name = "Project Import: foo") registered - this might lead to crashes on shutdown.

Merge request reports