• Agata Cacko's avatar
    Revert "Remove KisTool::notifyMdified" · d0602e63
    Agata Cacko authored
    This reverts commit 8ef85fdd.
    
    This commit fixes issue with autosave only saving once per manual save.
    Possibly it also fixes the issue with editing time being way lower
    than expected.
    
    ---
    
    Mentioned commit removed sending signal KisImage->notifyModified()
    by KisFreehandTool. Turned out that signal was important for autosave
    to work correctly and _possibly_ for counting time spent on the painting.
    
    Theoretically this signal should be also sent by strokes, rendering
    sending signal here redundant (hence the previous commit with
    "It is not used anymore" message). This requires further investigation
    and then recommitting these changes after making sure all logic is
    performed as before.
    
    Looks like the course of action with the signal from the Freehand tool was
    as follows:
    
       Freehand Tool sends ModifiedSignal
    -> Image Signal Router sends sigImageModified()
    -> KisDocument catches it and calls setModified( undoStackNotEmpty )
    -> KisDocument does a lot of logic and then sends modified()
    
    Supposedly strokes call KisDocument::setModified(...), at least on master.
    I can't confirm it because I didn't check the relevant code yet.
    But if that's true, that should be enough - all relevant logic happens
    inside this function. On the other hand, practice seems to prove
    otherwise...
    
    BUG:411631
    d0602e63
Name
Last commit
Last update
.github Loading commit data...
.gitlab/merge_request_templates Loading commit data...
3rdparty Loading commit data...
benchmarks Loading commit data...
build-tools Loading commit data...
cmake Loading commit data...
dev-tools/python Loading commit data...
interfaces Loading commit data...
krita Loading commit data...
libs Loading commit data...
packaging Loading commit data...
pics Loading commit data...
plugins Loading commit data...
sdk Loading commit data...
winquirks Loading commit data...
.arcconfig Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.lgtm.yml Loading commit data...
AUTHORS Loading commit data...
CMakeLists.txt Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COPYING Loading commit data...
COPYING-CMAKE-SCRIPTS Loading commit data...
CTestConfig.cmake Loading commit data...
HACKING Loading commit data...
KoAlwaysInline.h Loading commit data...
KoConfig.h.cmake Loading commit data...
Mainpage.dox Loading commit data...
Messages.sh Loading commit data...
README.md Loading commit data...
action_i18n.pl Loading commit data...
config-gsl.h.cmake Loading commit data...
config-hash-table-implementaion.h.cmake Loading commit data...
config-hdr.h.cmake Loading commit data...
config-hide-safe-asserts.h.cmake Loading commit data...
config-high-dpi-scale-factor-rounding-policy.h.in Loading commit data...
config-limit-long-tests.h.cmake Loading commit data...
config-ocio.h.cmake Loading commit data...
config-powf.h.cmake Loading commit data...
config-qtmultimedia.h.cmake Loading commit data...
config-set-has-border-in-full-screen-default.h.in Loading commit data...
config-vc.h.cmake Loading commit data...
config_convolution.h.cmake Loading commit data...
config_use_qt_tablet_windows.h.cmake Loading commit data...
extracti18n.pl Loading commit data...
kundo2_aware_xgettext.sh Loading commit data...
setup.cfg Loading commit data...