Skip to content

Prevent Amarok from stalling if the random playing mode is used and next file does not exist

Toni Asensi Esteve requested to merge work/not_stall_if_nonexistent_next into master

This issue was talked about in (bug 438651) Amarok stalls if the Previous Track button is pressed but the file not longer exists.

Hey Toni, indeed something similar should be implemented for the next track. That is, a loop until a playable track is found. Can you take care of this? The code from requestLastTrack() can be used as inspiration

I tried some experimental code (its source code is the one of this MR) though, sometimes, after pressing several times the Next Track button, the new Playlist::NonlinearTrackNavigator::likelyNextTrack() function never finishes. If that function is left as it was, then sometimes the new Playlist::NonlinearTrackNavigator::requestNextTrack() function never finishes.

Does the same happen to you, Pedro? Maybe the nextItemChooseDonorList() function has any problem? Or is there any problem somewhere else?

Edited by Toni Asensi Esteve

Merge request reports

Loading