Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Amarok Amarok
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MultimediaMultimedia
  • AmarokAmarok
  • Merge requests
  • !55
You need to sign in or sign up before continuing.

Port away from deprecated QDesktopWidget functions & disable missing OSD settings functionalities on Wayland.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Tuomas Nurmi requested to merge nurmi/amarok:osdPositioningUpdate into master Mar 11, 2023
  • Overview 1
  • Commits 3
  • Pipelines 12
  • Changes 6

Port away from deprecated QDesktopWidget functions, following the instructions on https://doc.qt.io/qt-5/qdesktopwidget-obsolete.html . It turned out that neither OSD positioning, screen selection nor translucency work at the moment (or probably ever have worked) on Wayland. Restoring these functionalities on Wayland won't probably be straightforward, so I suppose it makes sense to just disable/hide non-functioning OSD settings there for now.

Edited Mar 19, 2023 by Tuomas Nurmi
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: osdPositioningUpdate