Skip to content

fix dropdown bugs

Théophile Gilgien requested to merge tgilgien/audiotube:searchDropdown into master

fix issues with temporarySearch in search dropdown

Handling temporary searches the same as normal ones created issues when the temporary search was the same as a normal one. The normal search could get temorarily removed, and the temporary search would not display normally. Handling temporary and normal searches separately seemed easier. However, keeping the temporary searches completely separated and only in the qml would have complexified greatly the already complex handling of keyboard navigation, so keeping both in the model, but separated, seemed to be the easiest option.

fix popup being to large when opening with few entries

This requires knowing the height of one search entry, which is surprisingly difficult. For keyboard navigation, completitionList.empiricDelegateHeight was used. However, this can't be used in this concept, because it requires mainScrollView.contentHeight to be defined, which is not the cas at this stage. Fortunately, it doesn't to be extremly accurate, as it is only used if there are less than 11 search entries, so a small error doesn't adds up and is therefore unnoticeable.

The initial situation :

result :

Edited by Théophile Gilgien

Merge request reports