Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Elisa Elisa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Multimedia
  • ElisaElisa
  • Merge requests
  • !236

Open
Created May 02, 2021 by Han Young@hanyoungDeveloper
  • Report abuse
Report abuse

WIP: fix bug 436405: MetaData isn't updated while there is not metadata at all

  • Overview 1
  • Commits 2
  • Pipelines 4
  • Changes 2

Trying to fix https://bugs.kde.org/show_bug.cgi?id=436405

Contains two fixes:

  • entry doesn't get inserted into tracks table when the track's metadata doesn't contain title. Fix: use track's name as title
  • lyric doesn't get updated when the lyric is empty. Fix: update empty lyric but don't insert lyric entry to TrackMetaDataModel

Known issue:

  • tracks that don't have metadata on playlist is marked invalid on second load (add it to playlist and exit then re-open, track is invalid)
  • on fallback, using track file name as metadata's title isn't technically correct
Edited May 03, 2021 by Han Young
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/bug436405