Skip to content

Various refactorings

Jack Hill requested to merge jackh/elisa:various-refactorings into master

Reason for the change

  • Some code was unused
    • Support for tree-views. Its only use was removed in the same MR it was added in, 3 years ago. Can be re-added in the future if needed.
    • Buttons that were set to never be visible
  • Refactor {Grid,List}BrowserDelegate.qml to use actions instead of buttons
    • Will make it easier to port the List delegate to ActionToolBar in the future (currently blocked since this component doesn't allow triggering the button when pressing Enter)
    • Will be able to re-use these actions for the mobile context menu (when the BottomDrawer is added, or when MenuDialog allows auto-closing after clicking menu items)
    • In the future hopefully the grid and list views will have the same interface (and thus re-use the same actions) so that the user can switch between grid/list mode.
  • Fix signal injection & non-existing property warnings that appear on Qt6 builds

Test plan

Interact with grid/list browsers

  • Tooltips still appear on hover
  • Can still use keyboard navigation
  • Buttons still have the same behaviour

Merge request reports