Skip to content

Always open a view as a child when not opened from the sidebar

Jack Hill requested to merge jackh/elisa:view-history into master

Reason for the change

Previously if the artists list was embedded into the sidebar and we tried to open an artist from an album page the view history was reset. I think the expected behaviour is a view is only a parent view if explicitly opened from the sidebar, whilst all other views are opened as child views.

Test plan

  • Set the embedded category to Artists
  • Open an album view
  • Click the album secondary text to go to the album's artist page
  • Click the artist text in the header bar to go the the currently-playing artist page

Before: The artist page would be opened as a base view, view history was reset, and the sidebar would scroll to the corresponding artist

Now: The artist page is opened as a child view and is pushed onto the view stack. The sidebar is unchanged.

Bugs fixed

CCBUG: 468212

Merge request reports

Loading