Skip to content

Improve color scheme menu

Jack Hill requested to merge jackh/elisa:improve-colorScheme-menu into master

Reason for the change

Makes the color scheme menu look better. Continuation of !339 (closed)

Test plan

Desktop

  • Open color scheme menu from application menu

Before: big menu items

Now: menu icons follow menu theming. They also have checkboxes

Mobile

  • Run Elisa with QT_QUICK_CONTROLS_MOBILE=1 QT_QUICK_CONTROLS_STYLE=org.kde.breeze kdesrc-run elisa
  • Press ctrl+shift+, to open the config page
  • Click the color scheme combo box

Before: big menu items. Color scheme menu was a button.

Now: menu icons follow menu theming. Color scheme menu is now a combobox

Screenshots or screen recordings

Desktop

Before After
color-desktop-before color-desktop-after

Mobile

Before After
color-mobile-before color-mobile-after

Bugs fixed

BUG: 447941

Edited by Jack Hill

Merge request reports