Skip to content

Improve metadata form

Jack Hill requested to merge jackh/elisa:metadata into master

Reason for the change

A collection of fixes to improve the state of the metadata editor and make it more intuitive.

  • Use scrollable page for desktop form to fix the content not being scrollable for me (also removes the weird extra padding that appears on the radio form)
  • Fix the delete radio button not closing the form on mobile
  • Removes the big space above the radio form
  • Use i18n for appending a colon character
  • Make form labels bold on mobile to distinguish the label from the metadata. Personally I would prefer to actually make the label stand out less by reducing the opacity, but I'm not sure if this is possible with html.
  • Add tooltip to metadata delegate's delete button
  • Make some properties aliases to avoid destroying bindings
  • rename some variables to improve readability
  • Don't overwrite changes immediately so we can have a Cancel button
  • Streamline form buttons/actions
  • Display a dialog when closing the form with unsaved changes

Desktop form buttons

When not creating or editing:

  • Modify starts editing form
  • OK closes form

When editing:

  • Apply applies changes & exits editing mode
  • Cancel undoes any changes & exits editing mode
  • OK applies changes & closes form

When creating:

  • OK creates radio & closes form
  • Cancel stops creating radio & closes form

Mobile form actions

When not creating or editing:

  • Modify starts editing form

When editing:

  • Save applies changes & exits editing mode
  • Cancel undoes changes & exits editing mode

When creating:

  • Save applies changes & closes form
  • Cancel stops creating radio & closes form

Test plan

  • Try adding/removing/editing various tags in the metadata form
  • Try closing the form after modifications have been made
  • Try adding a new radio

All work fine

Screenshots or screen recordings

Mobile/Desktop Default form Modify form Radio form Modify radio form Create radio
Desktop desktop-form-default desktop-form-modify desktop-form-radio-default desktop-form-radio-modify desktop-form-radio-create
Mobile mobile-form-default mobile-form-modify mobile-form-radio-default mobile-form-radio-modify mobile-form-radio-create
Edited by Jack Hill

Merge request reports

Loading