Skip to content

Fix page header click events propagating into main ScrollView

Jack Hill requested to merge jackh/elisa:bug/header-dataview into master

Reason for the change

The page header previously ignored click events, so these were sent to the underlying scrollview. qqc2-desktop-style would clip ScrollView, which is why this wasn't noticed earlier.

To solve this I have ported HeaderFooterToolbar to a QQC2.ToolBar, which handles focus/mouse clicks for us. This is probably more efficient than clipping the ScrollView.

Test plan

  • Open albums view
  • Set view-mode to grid
  • Scroll the page down slightly, so that an album image is underneath the header toolbar
  • Click in an empty space in the toolbar

Before:

  • The click is accept by the ScrollView, and an album page opens

Now:

  • The click is intercepted by the toolbar and nothing happens

Merge request reports