Skip to content

Port away from GraphicalEffects

Jack Hill requested to merge jackh/elisa:refactor/graphical-effects into master

Reason for the change

  • We should not depend on deprecated libraries

  • I have tried to reproduce the original effect where possible but unfortunately there are no 1:1 replacements for each effect

  • I intentionally changed the rating star effect because, IMO, it was such a small effect that it was not noticeable

  • All of the blur effects have changed significantly. This is because the FastBlur in Qt5 has no direct replacement, as the Qt6 MultiEffect uses a Gaussian blur (I think). This could be fixed by using a custom shader which I can look into using if we need it (see https://www.qt.io/blog/in-depth-custom-shader-effects and https://git.qt.io/esabraha/boxblurblog). I have no idea how the performance of shaders compares to MultiEffect

  • Personally I preferred the old blur over the new one

Test plan

Use the app as normal.

Screenshots or screen recordings

Component Before After
Context view background elisa-contextview-before elisa-contextview-after
Grid browser delegate shadow elisa-gridview-before elisa-gridview-after
Header bar background elisa-headerbar-before elisa-headerbar-after
List browser delegate shadow elisa-listview-before elisa-listview-after
Mobile footer background elisa-mobile-footer-before elisa-mobile-footer-after
Mobile player background elisa-mobile-player-before elisa-mobile-player-after
Mobile toolbar background elisa-mobile-toolbar-before elisa-mobile-toolbar-after
Rating star (selected 4 stars, hovered over 2nd star) elisa-rating-before elisa-rating-after
Edited by Jack Hill

Merge request reports