Skip to content

Fix issues with other Qt Quick styles by using implicitHeight rather than hardcoded heights

Jack Hill requested to merge jackh/elisa:refactor/style-issues into master

Reason for the change

We were hard-coding toolbar heights, which meant content items that were larger than this height would overlap the boundaries of the toolbar. Now we determine the height of the toolbars from the implicit height of the items.

Test plan

  • Run the app in mobile & non-mobile for a range of styles
  • Look at the buttons in the global toolbar, page toolbar, and playlist toolbar

Screenshots or screen recordings

Style Before After
Material (look at search bar) Material-before Material-after
Universal (look at main toolbar and searchbar) Universal-before Universal-after
Breeze (page & playlist toolbar heights are now smaller) Breeze-before Breeze-after

Merge request reports