Skip to content

Configuration: Replace old style declarative Binding and an oddly specific property

ivan tkachenko requested to merge work/r/property-qqc2 into master

Reason for the change

  • The standardButton() method is not observable, so it does not matter if we use it for a property or in a one-shot onCompleted hook.
  • Properties should be using Templates version for maximum flexibility. The NOTE on the property technically might be right (for some style implementations), but it is completely irrelevant, as the only thing we care about here is the Item::enabled property.
  • The onCompleted hook is a well established idiom for customizing standard buttons in dialog button boxes.

See also: https://bugreports.qt.io/browse/QTBUG-120189
CCBUG: 487904

Test plan

  1. Run Elisa
  2. Open Configuration window
  3. Make sure the Apply button is disabled
  4. Change some preferences
  5. Make sure the Apply button became enabled
  6. Revert your changes
  7. Make sure the Apply button returned back to the disabled state
Edited by ivan tkachenko

Merge request reports