Skip to content

Rework the metadata dialog to be more intuitive

Jack Hill requested to merge jackh/elisa:refactor/metadata-dialog into master

Reason for the change

  • Fix a bug where the lyricist value was not being saved when edited
  • Rework the way tags are added to be more intuitive
  • Fix a bug where the Create a Radio dialog incorrectly showed an error message
  • Fix a graphical glitch when switching between read-only and modify mode in the metadata dialog

Test plan

  • Open the metadata dialog
  • Start modifying
  • Add some tags, delete some tags
  • Press apply
  • Check the tags have been written correctly

Create a Radio:

  • Open the Create a Radio dialog
  • Enter a valid URL into the input box

Previously: an error message appeared even if the URL was valid. Now: the error message appears only if the URL is invalid.

Screenshots or screen recordings

Before After
elisa-metadata-before elisa-metadata-after
elisa-radio-before elisa-radio-after

Bugs fixed

BUG: 480177

Merge request reports

Loading