Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Elisa
Elisa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Jobs
  • Commits
  • Multimedia
  • ElisaElisa
  • Merge Requests
  • !98

Merged
Opened Mar 07, 2020 by Alexander Stippich@astippichDeveloper

Never emit dataChanged signal when inserting new entries

  • Overview 1
  • Commits 1
  • Changes 3

dataChanged signal is for existing items. Hence, do not emit it when actually new items are added. Hopefully fixes the test failure after the shuffle playlist merge (https://build.kde.org/job/Applications/job/elisa/job/kf5-qt5%20FreeBSDQt5.13/), since the dataChanged signal was incorrectly emitted even before the endInsertRows signal was emitted when restoring entries.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: multimedia/elisa!98
Source branch: fixMediaPlayList