Draft: Don't DropInvalidChars when opening project XML (!294) · Merge requests · Multimedia / Kdenlive

Eric Jiang requested to merge erjiang/kdenlive:do-not-drop-invalid-chars into master Apr 30, 2022

Setting DropInvalidChars seems to drop all valid Unicode characters outside the BMP, such as U+1F861 (reported in BUG: 435768).

To test: try creating a title with the text "test🡡test" (Wide-Headed Upwards Light Barb Arrow). Confirm that the title appears correctly in the preview even after saving the file, restarting Kdenlive, and opening the file.

I would be curious to hear what risks we'd have by not setting DropInvalidChars. The current state of silently corrupting files is bad though.

Edited May 03, 2022 by Eric Jiang

Draft: Don't DropInvalidChars when opening project XML

Merge request reports