Skip to content

Actions to add quick add guides in three categories

Theo Shaw requested to merge ttshaw/kdenlive:master into master

The goal is to have a set of hotkeys which will let me quickly insert guides in different categories. E.g. numpad 1 places a category 1 guide, numpad 2 places a category 2 guide, etc. This should make it easier to watch a recording and add guides corresponding to various classes of events. It's functional and I'm using it in editing some of my videos.

The Action (slotAddMarkerGuide1, 2, or 3) works by changing the guide category then doing the usual routine for Add Marker/Guide Quickly.

There are a good number of issues I'd like to figure out. But it's up to y'all if we can merge before getting through all of this.

  1. Should I be calling Add Marker/Guide Quickly from the action I have instead of reusing the code in my action?
  2. Can I query the current default guide category? KdenliveSettings has a setDefault_marker_type() but no getDefault_marker_type(). It would be nice to return to the old category after placing the one in my Action.
  3. If not, I'll need to update the colored category preview icon in the Guides pane when taking my Action, since it stays on the last category that was selected in a more typical way.
  4. The Action(s) shows up in the keyboard shortcuts menu, but not in Clip->Markers as I'd expect from modifying kdenliveui.rc
  5. The shortcut to select video track with a number key takes precedence over using the numpad number keys for a different Action. Is there a way to specify when I customize shortcuts that I want only the non-numpad number keys to count for an Action? If not, can we make it so that if a numpad shortcut exists, it has priority over non-numpad number shortcuts?
  6. Need translation strings
  7. There's a segment of code that I didn't understand where the Action is connected to the clip and project monitors. I used &Monitor::addMarker, which matches the Add Marker/Guide Quickly action. I don't know enough about this connection concept to know if this is a problem.
  8. Instead of repeating each block of code for each category, where can I use the category number as an argument?
Edited by Theo Shaw

Merge request reports

Loading