Skip to content

FrameTable: display header title for SubFramesEditor

Gary Wang requested to merge garywang/kid3:header-title into master

This patch will let SubFramesEditor show header text instead of hiding it and leave a 2px height header empty header.

image

The reason for this patch is I found in version 3.8.4 will set the header height to 2px and will also display text, which makes the text unreadable. While I pulled the source code and try to find out why the header height looks "incorrect", I noticed in e2cdb749 there already have a fix that will hide the text.

I saw there is a comment which says ...

   // Set a small height instead of hiding the header, so that the column
   // widths can still be resized by the user.

... but I'm not sure if this place is also intended to hide the header. Since KId3Form chooses to hide the header text and I'd like to keep that behavior as-is, so I added a function that can be used to know if the header is set to empty and the height will be set to 2px if it is.

If hiding the header text here (in SubFramesEditor) is intended, feel free to close this Merge Request.

Thanks!

Merge request reports