Skip to content

Navigation bar: processing URL and address entry via overlay

Rinigus Saar requested to merge rinigus/plasma-angelfish:nav into master

This splits URL display and entry into two different parts. URL is shown on navigation bar as a legend with processed entry that separates scheme, host, and path. All this is made to show main part of the used URL and label that if we can (HTTPS vs HTTP).

Next, I moved editing URL into separate overlay. This increased amount of space used for text and allowed to join search with URL entry into the same location.

Few remarks:

When we click on address, would be great to see bookmarks. That way we could get to them fast.

Looks like there are some glitches when overlay is shown on phone. As if its going to max, then reduce itself, and then stabilize. On hiding, there are similar glitches. If you swipe down, before disappearing, its shooting up and then disappears.

Have to ask on Kirigami channel, but we should somehow reduce the swiping distance to get it out of the way easier. 1/2 of full height is surely too much to start that operation.

I did put the address entry into header. Alternative would be footer and let it not cover full page. But that would induce issues on Sailfish as I still have to work on keyboard covering flatpak apps sometimes. In addition, it's uncommon to have search string entered below the text. Finally, addressbar will be visible then on specific strings and may distract.

Related to #5 (closed) . Its not fully resolved as bookmarks are not show.

Again, if you think its too large change and design is off, let me know.

Merge request reports

Loading