Skip to content

Settings update

Rinigus Saar requested to merge rinigus/plasma-angelfish:settings into master

This MR fixes issues #27 (closed) and #24 (closed)

#27 (closed) was a nasty one, as it surfaced right now only on Flatpak (PC and mobile).

In addition, I suggest that I will move homepage and searchBaseUrl from BrowserManager to Settings.qml. I think it makes more sense to keep it there and remove all settings related handling in BrowserManager as it is not used.

Only place which relies on BrowserManager settings is loading of homepage by TabsModel. In this occasion, we can just load it from QSettings as well.

As result, BrowserManager would become way smaller and cleaner. As for Settings, it will be minor increase but better partitioning of the code.

Should I do those changes as well?

Merge request reports