Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Kaidan
Kaidan
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 46
    • Issues 46
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 15
    • Merge Requests 15
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Network
  • KaidanKaidan
  • Merge Requests
  • !601

Merged
Opened Aug 26, 2020 by Linus Jahn@lnjDeveloper

Do not interpret random URLs as files anymore

  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 2

Random links like 'https://conversations.im/omemo/' were interpreted as file previously, although that makes no sense at all.

When receiving a message, we also check the message body for interesting URLs like images or geo location URIs. However, we do not want any link to be recognized as file, so we need to ignore some from the body here.

The new tactic is to accept all URLs set via the out of band URL (XEP-0066), but to only accept image, audio, video and document files from the message body. Other links (like html websites) are ignored.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: network/kaidan!601
Source branch: no-random-urls-as-file