Add links and comply with GPL
Summary
This MR has 2 purposes:
- Comply with our license and other open source licenses
- Bring in some items from the "Help" menu standard desktop KDE apps, such as Kate
It adds 4 links on the global settings page (KDE Connect > Menu icon > Settings):
- Report Bug
- Donate
- Source Code
- Licenses
Report Bug
This is just a nice-to-have thing, and encourages users to use our bug tracker instead of writing Google Play reviews.
Donate
Let's do our part in fundraising just like the desktop KDE apps.
Source Code
This will help us reach more potential contributors.
It is also required to comply with the GPL
- [...] you also do one of the following:
a) [...] b) Accompany it with a written offer, valid for at least three years, to give any third party, for a charge no more than your cost of physically performing source distribution, a complete machine-readable copy of the corresponding source code, to be distributed under the terms of Sections 1 and 2 above on a medium customarily used for software interchange; or, c) [...]
[...]
[...] they could even be mouse-clicks or menu items--whatever suits your program.
I wasn't able to find links directly to GitLab from any desktop apps yet, but desktop users either have the source or know how to get the source from their package managers. However, on mobile, there is no guarantee of there being a package manager that hyperlinks to the source. Therefore, we need to add a link ourselves.
Even if we can easily (since this app is 100% FOSS) do this later, doing it now will deter a CraftBukkit-style DMCA of our Google Play listing, even if temporary.
Licenses
Most open source license require that the license text is preserved and displayed. The GPL, for example, says:
- You may copy and distribute verbatim copies of the Program's source code as you receive it, in any medium, provided that you conspicuously and appropriately publish on each copy an appropriate copyright notice and disclaimer of warranty; keep intact all the notices that refer to this License and to the absence of any warranty; and give any other recipients of the Program a copy of this License along with the Program.
The menu item I added is actually directly recommended:
[...] they could even be mouse-clicks or menu items--whatever suits your program.
Test Plan
There should be no changes except for those 4 new items.
The first 3 items correspond to certain items in the "Help" menu of KDE desktop apps, and should behave similarly. The 4th should display all legally required licenses, implemented using a dialog.
Before
After
