Skip to content

Remote keyboard UI update

Adrijan Rogan requested to merge arogan/kdeconnect-android:arogan/remotekeyboardupdate into master

Summary

The intent of this patch is to update the UI/UX of the remote keyboard plugin. It is related to the T10232 Phabricator task. I have considered using the key appearance, however I went for a more flat and simple look. The following UI related changes have been made:

  1. Removed KeyboardView usage (which was deprecated in API 29 and is targeted mainly at "real" keyboards), we can return any View that we like. The UI is split into two parts, leveraging the provided APIs distinction between the input view and the candidates view. The main part is the input view that contains three actions, similar to the old keyboard.
  2. The candidates view is used instead of Toast for displaying connection details upon clicking the state action (the phonelink icon). It has a simple fade-in animation for this view.
  3. The keyboard actions have a grayish ripple effect on Lollipop or higher and a simple grayish background change on pre Lollipop.
  4. The preferences screen does not constrain the text to single line anymore.
  5. Theming based on user preference for the app on API 17+, 14-16 uses system preference. If a change happens (either user switches app theme or the system does it), the keyboard views are automatically recreated.

Notes and considerations

There are some other changes and comments worth mentioning:

  1. I have added four colors (two for night qualifier and two for without any). However, I feel these colors should already been defined and used, especially as we inherit a material theme. Themes, styles, colors and text appearances are not utilized enough and it is something I would like to work on in the future to achieve a more uniform look across the app (and correctly style snackbars, I have seen the TODO).
  2. There are two additional strings and the two that were already there have been reworded to be more user friendly. How are localization changes handled?
  3. It's quite taller than the older keyboard; I can reduce padding if this is an issue.

TODO

  1. Research icon colors on pre 21 devices, I have seen issues with dark theme

Test Plan

The remote keyboard functionality should stay exactly the same, as I have only touched the UI parts of the plugin. Please report any theming issues/inconsistencies (especially older API versions), UI suggestions and feedback.

Video:

arogan_remotekeyboardui1

Edited by Adrijan Rogan

Merge request reports