Skip to content

Basic support for A12 colors. Colors don't work in some cards, menus and the hamburger menu

Arun Parolikkal requested to merge thisbeme/kdeconnect-android:master into master

Summary

I'm trying to make KDEConnect pull colours from the Material 3.0 wallpaper in Android 12. I've managed to do this to an extent by editing the xml files in res/values*. There are, however, certain UI elements that do not respond to the changes I've made, with no obvious files where their colours may be changed.

Screenshots

The devices screen looks great (Except "KDE Connect Devices" in the App bar isn't themed.)

Screenshot_20211215-175156_KDE_Connect

The hamburger menu has a white color in light mode. Don't know where this is set and how to change it

Screenshot_20211215-175206_KDE_Connect

Three dot menu has a white colour

Screenshot_20211215-175210_KDE_Connect

Add new devices looks good too

Screenshot_20211215-175221_KDE_Connect

Not the popup menus though

Screenshot_20211215-175225_KDE_Connect

Cards in the About section are still white

Screenshot_20211215-175235_KDE_Connect

Dark mode works fine

Screenshot_20211215-175255_KDE_Connect

But again, some UI elements like the hamburger menu aren't themed.

Screenshot_20211215-175302_KDE_Connect

I'll keep trying to figure out how to make these elements to their proper colours, but I've done a lot of searching through the source and couldn't figure out how. I'm absolutely new to Android development. Help please.

Test Plan

For the changes made thus far, none are needed.

Edited by Arun Parolikkal

Merge request reports