Skip to content

Use colon instead of hyphen when building command control ids

Matthew Mirvish requested to merge mincrmatt/kdeconnect-android:use-colon-in-controlid into master

Certain implementations of the protocol (namely GSConnect) use UUIDS for the device IDS/command keys, which contain hyphens in them. The current implementation of RunCommandControlsProviderService (used for the android 11 power menu command control things) gives the controls unique IDS with "{deviceid}-{commandkey}" and then tries to split on the hyphen, which obviously breaks if the device id or command key contain hyphens. This patch changes it to uses colons to separate them instead.

Note that I've only tested this with GSconnect, but I see no reason why it wouldn't work with the normal KDE connect implementation too, unless it uses colons in IDs.

Merge request reports