Skip to content

Set android:exported to true for activities with intent filters

Krut Patel requested to merge iamkroot/kdeconnect-android:export-activities into master

Summary

Sets android:exported property to true in AndroidManifest.xml for activities that define intent-filter.

The docs state-

If an activity in your app includes intent filters, set this element to "true" to let other apps start it.

Before SDK 16, this defaulted to true when not specified in the manifest, and hence the activities were automatically exported. With 6fbd923c changes, this was set to false, making these activities "unlaunchable" from other apps.

In particular, this caused "Send as Keystrokes" activity to be hidden (first introduced in !220 (merged)) from the activity chooser popup.

Test Plan

Before:

  1. Open andOTP
  2. Click "Share as Keystrokes" for any entry (new users will need to set up a 2FA before this).
  3. Notice only "Send to Device" option in the app chooser popup, "Send as Keystrokes" is missing.

After:

Same as above, but "Send as Keystrokes" also shows up.

Merge request reports