Skip to content

SystemVolumePlugin: Do not call requestSinkList once per second on Windows

Albert Vaca Cintora requested to merge work/fix-requestSinkList into master

The MPRIS-equivalent plugin for Windows sends player updates once per second. This calls the MprisMediaSession's updateMediaNotification function which then calls updateCurrentPlayer which used to call SystemVolumeProvider's startTrackingVolumeKeys (now renamed to startListeningForSinks) which on each call:

  • It would add yet another copy of this to the listeners list
  • It would send a network packet to get the sinks from the other device

Now we only call startListeningForSinks when the tracked player changes.

Merge request reports