Skip to content

Add option to disable/enable clipboard auto-share

Saif Masoud requested to merge saifmasoud/kdeconnect-android:clipboard-autoshare-pref-2 into master

Summary

Added an option to enable/disable auto-sharing the clipboard (This is already a feature on the desktop version, and is different from enabling/disabling the entire plugin as manual sharing still works).

Also made it so that the send clipboard action button shows up whenever auto-share is disabled (Even if the app has necessary permissions to auto-share, user should have the option of manual sharing if they disabled auto-sharing).

Notice the new vertical bar on the plugin settings page: Screenshot_2024-01-31-22-36-50-038_org.kde.kdeconnect_tp-edit

The new auto-share preference toggle:

Screenshot_2024-01-31-22-30-22-585_org.kde.kdeconnect_tp-edit.jpg

Known issues:

  1. App needs to be closed & re-opened before the action button in device main view is correctly changed between being displayed/hidden
  2. Need to figure out how to show/hide the "send clipboard" action in the foreground notification based on the user's plugin preference

Fixes https://bugs.kde.org/show_bug.cgi?id=479919

Test Plan

I did some manual testing to verify that the clipboard sync, and button displaying/hiding, behave as expected when the auto-share is toggled on/off. I invite suggestions to improve this.

Merge request reports