Skip to content

Draft: Reworked custom device list

TPJ Schikhof requested to merge qazcetelic/kdeconnect-android:work/custom-device-list into master

Changes

  • Solved serialization issue when commas were used
  • Validate hosts (either a hostname, IPv4 adress, or IPv6 adress) and show toast message if host is invalid
  • Show whether device can be reached over the network
  • Show toast message when host already exists
  • Code TODO's (including sorting device list)
//TODO: Require wifi connection so entries can be verified
//TODO: Resolve to ip address and don't allow unresolvable or duplicates based on ip address
//TODO: Sort the list

I decided to show current connectivity status instead of validating whether the app can connect the host once when they are added, since this is more useful when debugging problems. However, I can also add a check when adding entries if that approach is preferred.

User Interface

image

Toast message when host 😄 is added. This toast is also triggered when an existing host is changed to something invalid and the user tries to save it.

image

Toast message when duplicate host is added.

image

Edited by TPJ Schikhof

Merge request reports