Skip to content

Use an AlertDialogFragment instead of an AlertDialog for Plugin.getErrorDialog()

Erik Duisters requested to merge eduisters/kdeconnect-android:alert_dialog_fragment into master

Summary

Use an AlertDialogFragment instead of an AlertDialog for Plugin.getErrorDialog() because:

  • An AlertDialog does not survive orientation changes
  • It is recommended by google see: dialogs

Test Plan

Revoke Notification access for kdeconnect Apply patch and verify that:

  • When you click on Notification sync a dialog is shown that looks the same as the old AlertDialog
  • The dialog survives an orientation change
  • When you click "OPEN SETTINGS" the systems "Notification Access" settings app is displayed

Merge request reports