Skip to content
  • Simon Redman's avatar
    Cache and delete old ConversationsDbusInterfaces to avoid memory leak · 74ba660c
    Simon Redman authored
    Summary:
    After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
    
    This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?
    
    Test Plan:
    - Run daemon
    - Hopefully experience no crashes after many phone reconnects
    
    Reviewers: #kde_connect, apol, albertvaka
    
    Reviewed By: #kde_connect, apol, albertvaka
    
    Subscribers: apol, kdeconnect
    
    Tags: #kde_connect
    
    Differential Revision: https://phabricator.kde.org/D16553
    74ba660c