Skip to content

MprisControlPlugin: setting canPlay & canPause to true for VLC.

Anjani Kumar requested to merge anjani/kdeconnect-kde:mpris into master

Summary

mpriscontrolplugin uses OrgMprisMediaPlayer2PlayerInterface::canPlay() and OrgMprisMediaPlayer2PlayerInterface::canPause() to findability of player to play or pause media and sends this to the Android app where the MprisPlugin uses to setup Media control options. However, these calls are not reliable in-case of VLC Media Player. This causes the play/pause buttons on Android control to get disabled. If I hardcode these values to true on Android it will affect all players, it is better to have it here.

BUG: 419553

Test Plan

Before:

Play media from VLC on desktop. Open Multimedia control activity or see the notification for media playback on Android. Clicking pause from Phone will disable the play button in the control activity and the button in notifications disappear.

After:

Play/Pause buttons on the Android controller works fine.

Merge request reports