Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KDE Connect KDE Connect
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • NetworkNetwork
  • KDE ConnectKDE Connect
  • Merge requests
  • !244

WIP: [findthisdevice] Use libcanberra for rining sound

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Nicolas Fella requested to merge nicolasfella/kdeconnect-kde:canberra into master Apr 19, 2020
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 4

Using libcanberra has some advantages. It does not rely on the oxygen sound being present, which is probably not the case in a non-Plasma install. Instead it uses the freedesktop.org sound theme spec to find an appropriate sound. This also takes into account the users configured sound theme. It also promises better latency than the QtMutimedia player.

In theory this could also work on Windows and macOS, but I haven't tested it and would like to have that confirmed before I kill the QtMultimedia codepath.

An open question is what to do with the configurable sound option. In theory we could pass the configured sound file name to canberra, but I'm inclined to kill that option since IMO it does not provide much value

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: canberra