Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KDE Connect KDE Connect
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • NetworkNetwork
  • KDE ConnectKDE Connect
  • Merge requests
  • !393

[SMS App] Fix message sending area from always having a white background

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Simon Redman requested to merge sredman/kdeconnect-kde:work/sredman/smsapp-fix-dark-theme-sending-area into master Apr 18, 2021
  • Overview 5
  • Commits 2
  • Pipelines 3
  • Changes 1

Summary

Replace the (deprecated and removed) reference to Kirigami.Theme.viewBackgroundColor with Kirigami.Theme.backgroundColor

This element is necessary in order to have theme hot-switching work correctly

BUG 434791

Test Plan

Before:

When using the KDE Connect SMS app in an un-modified dark theme, the message entry text box would be rendered as all white and text would correctly be rendered in white (making it un-readable).

This seems to be somehow related to a recent Kirigami version (it only happened to me after doing a distro upgrade and my ancient Kirigami installed to ~/.prefix does not reproduce the issue).

viewBackgroundColor was deprecated and apparently removed from Kirigami a version or two ago. Thus the coloring was no longer correct.

For screenshots and discussion, see bug 434791

After:

Text and background are rendered in the expected colours for the theme.

Edited May 23, 2021 by Simon Redman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/sredman/smsapp-fix-dark-theme-sending-area