Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KDE Connect KDE Connect
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • NetworkNetwork
  • KDE ConnectKDE Connect
  • Merge requests
  • !455

Add Translucent Icon for MacOS

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ryan Adolf requested to merge rianadon/kdeconnect-kde:macos-tray-inactive into master Mar 03, 2022
  • Overview 12
  • Commits 3
  • Pipelines 11
  • Changes 7

Summary

I've added a new icon for MacOS so that the indicator changes color depending on whether a device is connected. I copied the style of the Wireguard icon; the #000000 color is used but with 50% opacity. This ensures the icon displays correctly in both dark and light themes.

I decided to add a systrayActiveHook method to the helper as there's an extra bit of logic and an extra instance variable needed for the Mac menubar to switch icons.

After:

No devices connected Devices connected
inactive-light active-light
inactive-dark active-dark
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: macos-tray-inactive