Skip to content

Draft: Improve UX - integrate with firewalld, systemd, and provide a button to change Samba user password

Thomas Duckworth requested to merge tduck/kdenetwork-filesharing:better_ux into master

This merge request does multiple things:

  • Optionally integrates with systemd to check if the Samba service is enabled, and if not, prompt the user to enable it beforehand - disable with -DUSE_SYSTEMD=off
  • Optionally integrates with firewalld to check if the Samba service is allowed through the default zone, and if not, prompt the user to allow it - disable with -DUSE_FIREWALLD=off
  • Adds a button to change the default Samba user's password on ACLPage, in case they forget their password.
  • Restores padding within the Properties dialog - beforehand everything was crammed up against the border.
  • Makes the wording on MissingSambaPage less verbose.

These changes overall provide a better onboarding experience.

In the plugin's current state, if the Samba service was disabled, there would be a vague error then the user could continue to use the plugin, despite it being non-functional. These changes prevent the use of the plugin if the Samba service is not running. In the case of Samba being blocked by the firewall, the actual dialog to create shares would work fine, but they would never be accessible to other computers.

Merge request reports