Skip to content
  • Harald Sitter's avatar
    sftp: fix partial transfer resuming when copying to local · 8a04e100
    Harald Sitter authored
    Summary:
    the previous condition checked if the final target path size was >0,
    which it would only be when the file already exists (i.e. overwrite) in
    all other scenarios it would always be false and as such resuming wouldn't
    work. what we actually want to check is whether the part file is >0 (i.e.
    there's actual pending bytes to resume from).
    
    this makes resuming work when copying remote->local
    
    CCBUG: 417645
    
    Test Plan:
    - create file of suitably large size (1g)
    - `split -b somesize` the file into two segments
    - copy first segment to /tmp/file.part
    - connect to /tmp over sftp and copy the file there
    - progress starts at 50% and resulting file is same as input file
    
    Reviewers: ngraham, feverfew, bruns
    
    Subscribers: bruns, kde-frameworks-devel, kfm-devel
    
    Tags: #dolphin, #frameworks
    
    Differential Revision: https://phabricator.kde.org/D27872
    8a04e100