Skip to content

Allow loading of Thumbnailers using embedded json metadata

Alexander Lohnau requested to merge work/thumbnailer_json_metadata into master

This way thumbnailer plugins don't need to be loaded using the KServiceTypeTrader mechanism, but can use embedded json metadata. KServiceTypeTrader is planned to go away in KF6.

This also simplifies the code once the KServiceTypeTrader code path is dropped, because we can then load the metadata from the binary path and don't have to use KServiceTypeTrader to get the desktop file for the given binary.

By using KPluginInfo to convert the metadata to json on the fly, we don't need to do another query for the file on disk and then a reparsing of the desktop file. This is ~2.5 times slower and even requires a few more lines to implement.

Merge request reports

Loading