Skip to content

Fix starting in tray by removing redundant show() in main

Matthew Scheirer requested to merge matthews/ktorrent:master into master

Fixes #363852

Quoting my response in the bug report:

Were coming on the four year mark that I reported this and nobody ever fixed it, so heres the fix after an hour counting show() calls on GUI to make sure I wasn't missing something obvious with a one liner fix like this.

main doesn't need to show the GUI because GUI::loadState will already show the window whenever its appropriate on startup. This redundant call after constructing GUI just means the window always shows and happens after the check to start in the tray.

Removing it means the logic in loadState actually dictates if the window is shown on startup or not. Tested it with all the combinations of options - works as intended from what I can see.

Merge request reports