Skip to content

Always remove a Plugin from it's factory when removing from the GUI

Jack Hill requested to merge jackh/ktorrent:factory-remove-client into master

Fixes warnings that occur when KTorrent is closed and the Download Order plugin and/or the Magnet Generator plugins are active and the main torrent view is open

To test:

  • Enable download order & magnet generator plugins
  • Open the main torrent view
  • Quit KTorrent

Before:

Warning: 0x558c6a111640 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
Warning: 0x558c6a207070 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.

Now:

  • no warnings

Merge request reports