Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Ruqola Ruqola
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkNetwork
  • RuqolaRuqola
  • Merge requests
  • !99

Retain focus on the room search line edit when switching channels

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Milian Wolff requested to merge work/switch-channels-via-keyboard into master Nov 02, 2022
  • Overview 0
  • Commits 2
  • Pipelines 5
  • Changes 1

Changing a channel via the keyboard with the search line edit focused eventually ends up calling RoomWidget::setChannelSelected. This then calls:

    mRoomWidgetBase->messageLineWidget()->setFocus();

That means we can only change one room at most, and would have to press Ctrl+K again to re-focus the search line edit. That is very inconvenient and behaved differently in the past.

With this patch here, we retain the focus on the search line edit when it had it at the point we are triggering the room change. Thereby we can once again scroll through multiple channels easily.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/switch-channels-via-keyboard