Skip to content

Add support for focal points in media attachments

Joshua Goins requested to merge work/redstrate/media-attachment-improvements into master

It's finally here, one of the last remaining bit of the status composer 🎉

Focal points are now used in 16x9 thumbnails

If Tokodon is set to crop media attachments, the focal points are now used if found:

Before After
image image
image image

If no focal point is set, it should adjust back to the center of the image like before.

Fixed Status Composer, and focal point support

Three media attachments now work as expected, and the focal point is also reflected in the grid.

image

Improved edit media dialog

This dialog is overhauled (now it uses Kirigami.PromptDialog!) and support for editing focal points has been added. Descriptions now load properly, and the editing experience is snazzy. Not super happy with how it looks on mobile right now, but it should at least be a little usable.

Screencast_20230805_183338-2

TODO

  • Create a separate 23.08 backport fix for the media attachments
  • Test if this works with post editing, hopefully we don't need to do anything special?
Edited by Joshua Goins

Merge request reports