Skip to content

Do not reload accounts when initially setting the application proxy

Joshua Goins requested to merge work/redstrate/fix-odd-bug into master

This is quite the sneaky issue, but I think it goes like this:

  1. NetworkController is initialized by the QML engine and it's constructor is called
  2. setApplicationProxy is called within said constructor
  3. AccountManager's reloadAccounts is called, which in turn emits accountsReloaded
  4. accountsReloaded can trigger some signal handler in QML, in turn making the QML engine initialize NetworkController again

Now setApplicationProxy has an optional parameter used by NetworkController's constructor to prevent this situation from happening in the first place.

BUG: 492383

Merge request reports