Skip to content

Allow to use inbuilt NSIS compression modes

Thomas Friedrichsmeier requested to merge tfry/craft:work/nsis_inbuilt_compression into master

Update: Perhaps !72 (merged) is a better approach to address this problem?

External compression using 7za is fast and effective, but breaks the installer progress bar (installation appears to "hang" somewhere around 70% completion). This patch allows to use one of NSIS's inbuilt compression modes (zlib/bzip2/lzma).

Notes:

  • External compression was added, here: ec9b7570 reviewers @kfunk @bcooksley , author @vonreth
  • bzip2 compression results in roughly 30% larger installer size for RKWard, I expect similar numbers for other apps. This fine from my point of view, but may not be from a sysadmin point of view.
  • inbuilt lzma compression yields similar size as the current compression using 7za, but is - potentially much - slower, as only one CPU core is used. Not sure how much of a problem that is in practice.
Edited by Thomas Friedrichsmeier

Merge request reports