Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Akregator Akregator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PIM
  • AkregatorAkregator
  • Merge requests
  • !10

Treat feed IDs as unsigned everywhere

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tomáš Trnka requested to merge work/bug429444 into master Mar 28, 2021
  • Overview 3
  • Commits 2
  • Pipelines 4
  • Changes 11

This fixes several bugs introduced by commit 230b8f20 ("Port all instance of KRandom") which switched the random number generator used in FeedList::generateId() from KRandom to QRandomGenerator. The former generates positive signed integers while the latter generates unsigned ints. While TreeNode already used uint to store the IDs, other classes used plain int. Half of the newly generated IDs thus got mapped to negative values, confusing various validity checks.

BUG: 429444

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/bug429444