Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PIM EventViews
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PIMPIM
  • PIM EventViews
  • Merge requests
  • !50

AgendaView: fix misaligned layout of header & footer columns

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Friedrich W. H. Kossebau requested to merge work/kossebau/fixagendaheaderfooterlayout into master Nov 03, 2021
  • Overview 3
  • Commits 1
  • Pipelines 6
  • Changes 2

The old code relied QHBoxLayout equally distributing the content across the header and footer. Though that will try to be more graceful to elements hinting to like bigger sizes, thus then screwing over alignment with the columns in the actual agenda.

The new code instead uses a custom QLayout subclass which enforces equal header columns.

The patch also fixes the bad placement of week decoration elements messing into the actual day headers, and places it aligned with the time labels, where there is space.

Examples:

Tiny window (poor-human testing of RTL with --reverse):
Screenshot_20211103_182928

Giving a bit more space:
Screenshot_20211103_183314

Fullscreen (on small laptopscreen, so needed to switch to January to have long labels ;) ):
Screenshot_20211103_183402

@gditchfield @winterz

Edited Nov 03, 2021 by Friedrich W. H. Kossebau
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kossebau/fixagendaheaderfooterlayout