Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PIM IncidenceEditor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PIM
  • PIM IncidenceEditor
  • Merge requests
  • !22

Do not create duplicate tags

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Glen Ditchfield requested to merge gditchfield/incidenceeditor:create-tag into release/21.08 Sep 30, 2021
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 1

If an event with categories is cut & pasted, the pasted event has the same categories as the original but does not have the same tag-item relationships in Akonadi. (This is not the only way that categories and tags go out of sync.)

When the incidence editor opens the pasted event, it creates new GENERIC tags for the categories, duplicating the existing tag. Then it inserts the tag in the editor, thus making it dirty and causing unnecessary "Do you really want to cancel?" dialogs.

This patch creates PLAIN tags, merges them with existing tags, and does not dirty the editor.

BUG: 441846

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: create-tag