Follow-up from "Fix ContactInfoProxyModel"
The following discussions from !11 (merged) should be addressed:
-
@mlaurent started a discussion: qCWarning(KADDRESSBOOK_LOG)
-
@mlaurent started a discussion: why don't test if name().trimmed().isEmpty ? as you use it in next line ?
-
@mlaurent started a discussion: coding style KContacts::ContactGroup& group => KContacts::ContactGroup &group
-
@mlaurent started a discussion: ContactGroup &groupContacts
-
@mlaurent started a discussion: const auto t = fetchJob->items(); for (const Akonadi::Item &item : t)
-
@mlaurent started a discussion: add \n before {
-
@mlaurent started a discussion: &item
-
@mlaurent started a discussion: Q_REQUIRED_RESULT
-
@mlaurent started a discussion: const QModelIndex index
- constFirst
-
@mlaurent started a discussion: const QModelIndex ... +constFirst
-
@mlaurent started a discussion: extract "
groupContacts.data(idx).name().trimmed()
in a variable and reuse it after -
@mlaurent started a discussion: groupCacheRefIds
.reserve(...) -
@mlaurent started a discussion: remove extra ";"