Skip to content

Merge kio_pop3 into the pop3 resource

David Faure requested to merge work/dfaure/merge_pop3slave_into_resource into master
  • POPSession instanciates POP3Protocol directly
  • Port POP3Protocol from TCPSlaveBase methods to using QSslSocket directly
  • Replace KIO metadata with direct poking into the Settings class
  • This means jobs are synchronous, which is fine in an akonadi resource (AFAIK)
  • Use the Result class from kio_ftp for returning success+errcode+errstring
  • Remove support for prompting for user/pass, this is supposed to be done in the settings dialog already. Might be convenient to reintroduce this somehow though, in case of a typo in the password.
  • Implement GUI handling of SSL errors in a way that is similar to the imap resource

Tested via the unittest, and via creating a POP3 resource (with an SSL error that required accepting to continue) and sending myself two emails. Not sure what else to test.

Edited by David Faure

Merge request reports